Have a default configuration for the EndpointPicker#2341
Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom Feb 15, 2026
Merged
Have a default configuration for the EndpointPicker#2341k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 4 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Contributor
Author
|
I should probably add to the documentation, the default configuration, I take suggestions as to where to add it. |
nirrozenbaum
approved these changes
Feb 15, 2026
Contributor
nirrozenbaum
left a comment
nirrozenbaum
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks!
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
please document in a follow up PR 🙏 |
RyanRosario
pushed a commit
to RyanRosario/gateway-api-inference-extension
that referenced
this pull request
Mar 9, 2026
…2341) * Added a function to create the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * If no configuration is provided use the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Remove command line argument checks that force a configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Added a test of using the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
Apr 23, 2026
…gateway-api-inference-extension#2341) * Added a function to create the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * If no configuration is provided use the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Remove command line argument checks that force a configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Added a test of using the default EPP configuration Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Today if the EndpointPicker is started without a configuration an error is issued and it fails to start.
It would be better if instead, a default configuration was provided and the EndpointPicker would start. This may make it easier for people to begin working with the EndpointPicker.
This PR provides a default configuration if one wasn't provided to the EndpointPicker in its command line arguments, either in-line or in a "file". In addition a new unit test was added to test this new functionality.
The details of the configuration can be found in issue #2324.
Which issue(s) this PR fixes:
Fixes #2324
Does this PR introduce a user-facing change?: