fix: InitLogging verbosity ignored due to ctrl.SetLogger single-fulfillment#2363
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Feb 18, 2026
Conversation
k8s-ci-robot
added
size/S
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thank you very much for correcting my oversight when I tried to fix the startup logging. /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kaushikmitr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
RyanRosario
pushed a commit
to RyanRosario/gateway-api-inference-extension
that referenced
this pull request
Mar 9, 2026
elevran
pushed a commit
to llm-d/llm-d-inference-scheduler
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the logging setup in
pkg/common/observability/logging/logger.goto allow dynamic adjustment of the log level after the controller-runtime logger delegation. The main change introduces a shared atomic log level to ensure log verbosity can be updated at runtime.Logging configuration improvements:
atomicLevelvariable usinguberzap.NewAtomicLevelAt(zapcore.InfoLevel)to enable runtime log level changes across logger instances.InitSetupLoggingandInitLoggingto useatomicLevel, ensuring log level updates are reflected without needing to re-delegate the controller-runtime logger.InitLoggingto mutateatomicLevelbased on the providedopts.Level, supporting bothuberzap.AtomicLevelandzapcore.Leveltypes.