Update InferencePool helm chart to use FailOpen as default#2365
Update InferencePool helm chart to use FailOpen as default#2365k8s-ci-robot merged 10 commits intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @RyanRosario. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tested with: Test: Proof that default is FailOpen: Proof that users can still override: (also ran make vefify) |
|
@kfswain Ready for review |
fb1a49c to
27f152a
Compare
|
Below is the verification of FailOpen now returning 200 whereas FailClose returns 503 when EPP is broken. There were a few challenges here (order of operations):
These are the steps I used to verify: SetupAdditional Experimental SetupGood EPP, FailClose (already set previously and old default)**Expectation: ** 200 OK Received Good EPP, FailOpen (new default)**Expectation: ** 200 OK Received Break the EPPBad EPP, Fail OpenExpectation: Something other than 500/503 Received Bad EPP, FailClose (and break EPP again)Expectation: Failure (500 or 503) Received Ancillary TestI was concerned that these tests do not load the defaults that I specified; however, the only changes I made to the files was in the Helm chart itself and each time Helm picked up the new FailureMode. Ancillary ScriptPurpose: Quickly switch between Additionally, the |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, RyanRosario The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…s-sigs#2365) * Update InferencePool helm chart default to FailOpen * Revert InferencePool API default to FailClose, keep Helm default FailOpen * Update helm chart * Allow helm chart template to pass FailOpen configuration to it * Modify failureMode in values.yaml * Remove v1 inference types and CRDs from PR * Modify model name in documentation * Restore deleted line * Reverting change to documentation as requested * Revert inferencepool.md documentation. --------- Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Encourages use of FailOpen as the default failure mode in InferencePool in the helm chart
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: