Emit metrics on execution time of BBR plugins by asaadbalum · Pull Request #2379 · kubernetes-sigs/gateway-api-inference-extension

asaadbalum · 2026-02-19T11:35:14Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds observability for BBR plugin execution latencies by introducing a
bbr_plugin_duration_seconds histogram metric. This mirrors the existing
EPP inference_extension_plugin_duration_seconds metric and enables
identification of performance bottlenecks caused by specific BBR plugins.

Each plugin execution in the request path is timed and recorded with
extension_point, plugin_type, and plugin_name labels, using the
same bucket boundaries as the EPP equivalent.

Which issue(s) this PR fixes:

Fixes #2355

Does this PR introduce a user-facing change?:

NONE

netlify · 2026-02-19T11:35:22Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`d48fddb`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/699ab28768265e000833d4cb
😎 Deploy Preview	https://deploy-preview-2379--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2026-02-19T11:35:22Z

The committers listed above are authorized under a signed CLA.

✅ login: asaadbalum / name: asaadbalum (d48fddb)

k8s-ci-robot · 2026-02-19T11:35:23Z

Welcome @asaadbalum!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-02-19T11:35:24Z

Hi @asaadbalum. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nirrozenbaum · 2026-02-19T12:02:16Z

/ok-to-test

nirrozenbaum · 2026-02-19T12:05:54Z

 	modelHeader     = "X-Gateway-Model-Name"
 	baseModelHeader = "X-Gateway-Base-Model-Name"
+
+	executeExtensionPoint = "Execute"


can we call that "Request"?
we will eventually end up with mirrored picture of plugins, and the extension point marks whether it was executed in the request, or the response.

Suggested change

executeExtensionPoint = "Execute"

executeExtensionPoint = "Request"

Good catch, thanks.
Updated.

nirrozenbaum · 2026-02-21T21:06:43Z


 	"sigs.k8s.io/gateway-api-inference-extension/pkg/bbr/framework"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/bbr/metrics"
+	bbrplugins "sigs.k8s.io/gateway-api-inference-extension/pkg/bbr/plugins"


nit: can we remove the bbrplugins alias?
plugins in the context of bbr code are always bbr plugins

@nirrozenbaum
yes, absolutely.
Modified.

nirrozenbaum · 2026-02-21T21:10:04Z

/lgtm
/approve
/hold

holding in case you want to fix the nit, if not please unhold.

k8s-ci-robot · 2026-02-21T21:10:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asaadbalum, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add plugin processing latency histogram (bbr_plugin_duration_seconds) mirroring the EPP pattern. Instrument executePlugins() to record per-plugin execution time with extension_point, plugin_type, and plugin_name labels. Signed-off-by: asaadbalum <asaad.balum@gmail.com>

nirrozenbaum · 2026-02-22T08:12:15Z

/retest

nirrozenbaum · 2026-02-22T08:17:57Z

/unhold

nirrozenbaum · 2026-02-22T08:34:24Z

/lgtm

Thanks! 🙏🏼

Add plugin processing latency histogram (bbr_plugin_duration_seconds) mirroring the EPP pattern. Instrument executePlugins() to record per-plugin execution time with extension_point, plugin_type, and plugin_name labels. Signed-off-by: asaadbalum <asaad.balum@gmail.com>

k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 19, 2026

k8s-ci-robot requested a review from elevran February 19, 2026 11:35

k8s-ci-robot requested a review from nirrozenbaum February 19, 2026 11:35

asaadbalum force-pushed the issue-2355-bbr-plugin-metrics branch from 4b60d55 to 8c15708 Compare February 19, 2026 12:00

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 19, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2026

nirrozenbaum reviewed Feb 19, 2026

View reviewed changes

asaadbalum force-pushed the issue-2355-bbr-plugin-metrics branch from 8c15708 to 9dcf164 Compare February 19, 2026 12:24

asaadbalum requested a review from nirrozenbaum February 19, 2026 13:41

nirrozenbaum reviewed Feb 21, 2026

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2026

k8s-ci-robot assigned nirrozenbaum Feb 21, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2026

asaadbalum force-pushed the issue-2355-bbr-plugin-metrics branch from 9dcf164 to d48fddb Compare February 22, 2026 07:38

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2026

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2026

k8s-ci-robot merged commit 53970f1 into kubernetes-sigs:main Feb 22, 2026
11 checks passed

asaadbalum deleted the issue-2355-bbr-plugin-metrics branch February 23, 2026 07:51

	executeExtensionPoint = "Execute"
	executeExtensionPoint = "Request"

Conversation

asaadbalum commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

linux-foundation-easycla Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 19, 2026

Uh oh!

k8s-ci-robot commented Feb 19, 2026

Uh oh!

nirrozenbaum commented Feb 19, 2026

Uh oh!

nirrozenbaum Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

asaadbalum Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

nirrozenbaum Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

asaadbalum Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nirrozenbaum commented Feb 21, 2026

Uh oh!

k8s-ci-robot commented Feb 21, 2026

Uh oh!

nirrozenbaum commented Feb 22, 2026

Uh oh!

nirrozenbaum commented Feb 22, 2026

Uh oh!

nirrozenbaum commented Feb 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asaadbalum commented Feb 19, 2026 •

edited

Loading

netlify Bot commented Feb 19, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Feb 19, 2026 •

edited

Loading

asaadbalum Feb 22, 2026 •

edited

Loading