Conformance Helpers Should be Cleaned Up

[robscott]

What would you like to be added:
We currently have some duplicative methods that really should be unified before we add conformance tests for more types. For example, the following functions have significant overlap:

1. GatewayAndHTTPRoutesMustBeAccepted + GatewayAndTLSRoutesMustBeAccepted
   

   gateway-api/conformance/utils/kubernetes/helpers.go

   Line 231 in bca1f48

   func GatewayAndHTTPRoutesMustBeAccepted(t *testing.T, c client.Client, timeoutConfig config.TimeoutConfig, controllerName string, gw GatewayRef, routeNNs ...types.NamespacedName) string {

   
   

   gateway-api/conformance/utils/kubernetes/helpers.go

   Line 569 in bca1f48

   func GatewayAndTLSRoutesMustBeAccepted(t *testing.T, c client.Client, timeoutConfig config.TimeoutConfig, controllerName string, gw GatewayRef, routeNNs ...types.NamespacedName) (string, []v1beta1.Hostname) {

2. HTTPRouteMustHaveParents + TLSRouteMustHaveParents
   

   gateway-api/conformance/utils/kubernetes/helpers.go

   Line 396 in bca1f48

   func HTTPRouteMustHaveParents(t *testing.T, client client.Client, timeoutConfig config.TimeoutConfig, routeName types.NamespacedName, parents []v1beta1.RouteParentStatus, namespaceRequired bool) {

   
   

   gateway-api/conformance/utils/kubernetes/helpers.go

   Line 426 in bca1f48

   func TLSRouteMustHaveParents(t *testing.T, client client.Client, timeoutConfig config.TimeoutConfig, routeName types.NamespacedName, parents []v1alpha2.RouteParentStatus, namespaceRequired bool) v1alpha2.TLSRoute {

Why this is needed:
Our conformance tests have grown organically over the years. Although each change made sense in isolation, these changes have resulted in a high likelihood that we'll start to have unexpected variations between tests for different route types.

Note: This is going to be complex to resolve, it would likely be good for someone that already has experience writing and/or running conformance tests to work on this. It may also be good to agree on a direction in this issue before investing too much time in writing code for this.

[robscott]

/area conformance
/kind cleanup
/remove-kind feature

[mmamczur]

I looked at this code a bit yesterday.
I'm guessing it would be best if instead GatewayAndHTTPRoutesMustBeAccepted() one could use GatewayAndRoutesMustBeAccepted() and it works for all types of connected routes.
So the problem in general is that we have types that have similar structure (at least in the part relevant here), as these all have route.Status.Parents.
One options is that these could be read as unstructured (which doesn't look great). Another is to have some adapter per type implementing a function like GetStatus() . The problem is that you need to know what type you need to read upfront

gateway-api/conformance/utils/kubernetes/helpers.go

Lines 404 to 405 in bca1f48

	route := &v1beta1.HTTPRoute{}
	err := client.Get(ctx, routeName, route)

so you still don't know which adapter to use