Fix cors cel #4032
Merged
Fix cors cel #4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/L
rikatz
force-pushed
the
fix-cors-cel
branch
2 times, most recently
from
163aa28 to
aab7135
Compare
snorwin
suggested changes
Aug 27, 2025
rikatz
commented
Aug 27, 2025
| wantErrors: []string{"Invalid value: \"xpto/https://xpto.com\""}, | ||
| corsfilter: &gatewayv1.HTTPCORSFilter{ | ||
| AllowOrigins: []gatewayv1.CORSOrigin{ | ||
| "xpto/https://xpto.com", |
Member
Author
There was a problem hiding this comment.
@snorwin this is the test for the comment you did. I have also fixed the cel regex :)
snorwin
approved these changes
Aug 27, 2025
robscott
approved these changes
Aug 28, 2025
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tylerauerbeck
pushed a commit
to tylerauerbeck/gateway-api
that referenced
this pull request
Nov 27, 2025
* CORS: support a single wildcard entry as origin * CORS: Add test for CRD validations
RoseWrightdev
pushed a commit
to RoseWrightdev/gateway-api
that referenced
this pull request
Jan 8, 2026
* CORS: support a single wildcard entry as origin * CORS: Add test for CRD validations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3648
Does this PR introduce a user-facing change?: