-
Notifications
You must be signed in to change notification settings - Fork 168
Move VAC storage API to v1 from v1beta1. #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Move VAC storage API to v1 from v1beta1. #2175
Conversation
Change-Id: I79888b0ecfb327ac9da788be6b1224c6699400c6
Change-Id: I2d78a565098a10fa8c64f6b4ea96f9397462d202
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nathanielford The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @nathanielford. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We also need to change the documentation in the OSS repo: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver?tab=readme-ov-file#kubernetes-version-recommendations Here we need to add a line for HEAD that it supports k/k 1/34+ |
Change-Id: I54b2ee7796207d56e05f92c793c3e4fe0073e946
/retest |
@nathanielford: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Change-Id: I71f4d77902762735fd110daae4459785a3ca7095
dbfe64e
to
7e1573d
Compare
/retest |
@nathanielford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change-Id: I79888b0ecfb327ac9da788be6b1224c6699400c6
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The feature-gated VAC enhancement (kubernetes/enhancements#3751) will be on by default in the v1 API, which gcp-compute-persistent-disk-csi-driver will support going forward.
Special notes for your reviewer:
This is my first PR, so any feedback you can give me on how to improve any aspect of it will be appreciated!
Does this PR introduce a user-facing change?:
NONE