frontend: Missing restart option despite enough permissions

[wiswesser]

Describe the bug

The only permission a user needs to restart a resource is the ability to patch the resource. It follows that a user with e.g. the permission to patch a deployment should also see the option to restart the deployment in headlamp. This is however not the case.
The reason is that Headlamp checks if the user has the "update" permission instead.
Inversely that also means that a user with only the ability to update deployments sees a Restart Button, but gets an error when trying to user it. (After all they are not authorised to do so).

To Reproduce

Steps to reproduce the bug:

1. Create a user with only the ability to patch, not update, deployments.
2. Confirm the ability to restart deployments by running "kubectl rollout restart deployment "
3. Switch to the deployment view in headlamp and click on the three dots
4. There is no restart button.

Environment (please provide info about your environment):

• Installation type: Windows (Though I suspect this does not matter)
• Headlamp Version: 0.41.0
• Other: None

Are you able to fix this issue?

If this is confirmed to be a bug that should be fixed, I'm happy to make a pull request replacing the update with patch. But I'll probably not have the time to test this thoroughly or anything.

Additional Context

[mishradwaterlaw]

/assign

[mishradwaterlaw]

Hey! Apologies for the mix-up I accidentally assigned myself to this issue using the assign command before noticing you were interested in working on it. 😅,,i went ahead and investigated the bug and put together a fix the root cause is in RestartButton.tsx where AuthVisible was checking authVerb="update" instead of authVerb="patch", even though the actual restart operation calls item.patch(). A one-line change fixes both broken behaviors described in the issue.

I have linked the PR and just realised it,, That said, if you'd still like to work on this, just let me know I'm happy to close my PR and unassign myself so you can take it from here. No pressure either way!

[wiswesser]

No problem! Feel free to work on this. My interest is in getting this fixed, and I'd have done it myself if necessary. But I much prefer someone else doing it :) So thanks for taking this on