frontend: Map: Various small fixes #3527
Merged
+107
−555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
size/XL
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Did you test that grey Pod word for visual constrast/a11y? |
Yes, I've tested contrast ratio for labels in the Map, it passes |
joaquimrocha
requested changes
Jul 11, 2025
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, sniok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GraphNodeDetails: Optimize rendering with useDeferredValue
Details rendering is now deferred, so when navigating the map details won't block the main rendering "thread"
graphLayout: Use worker for ELK layout
Layout calculation is now moved to a worker so it's not blocking main thread
GroupNode: Refactor Label styling
Labels for groups are now a bit nicer
Map: Adjust height to get rid of double scrollbar
Adjusted layout so there's no double scrollbar
Map: Use theme colors for map background pattern
Background dots are now using theme colors
Map: Avoid stale layout application in useEffect
Avoid unnecessary re-renders on rapid layout changes
Map: Adjust animation timings
Animations are a bit quicker
Map: Improve breadcrumbs label display
Breadcrumbs are now properly truncated and have a tooltip
