-
Notifications
You must be signed in to change notification settings - Fork 388
frontend: resourceMap: Unify network icon with sidebar #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blazethunderstorm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@illume pls review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you now squash your changes and change the PR & commit titles as described?
For example, the title can be frontend: resourceMap: Unify network icon with sidebar
@skoeva sure , thanks for your review |
@skoeva cant the commits be sqaushed while merging ? |
i am facing a bit of problem at my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this comment: #3595 (comment)
Summary
This PR fixes an icon inconsistency for the "Network" section by updating the icon used in the resource map filter to match the one used in the sidebar.
Related Issue
Fixes #3485
Changes
Updated the icon for the "Network" group in GraphSources.tsx
Replaced mdi:lan with mdi:folder-network-online for visual consistency
Steps to Test
Start Headlamp locally
Navigate to the Resource Map
Confirm that the Network icon in the sidebar and map filter now match visually
Screenshot