Skip to content

frontend: resourceMap: Unify network icon with sidebar #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

blazethunderstorm
Copy link

@blazethunderstorm blazethunderstorm commented Jul 7, 2025

Summary

This PR fixes an icon inconsistency for the "Network" section by updating the icon used in the resource map filter to match the one used in the sidebar.

Related Issue

Fixes #3485

Changes

  • Updated the icon for the "Network" group in GraphSources.tsx

  • Replaced mdi:lan with mdi:folder-network-online for visual consistency

Steps to Test

  1. Start Headlamp locally

  2. Navigate to the Resource Map

  3. Confirm that the Network icon in the sidebar and map filter now match visually

Screenshot

image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from skoeva and vyncent-t July 7, 2025 14:47
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blazethunderstorm
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@blazethunderstorm
Copy link
Author

@illume pls review

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2025
@joaquimrocha joaquimrocha requested review from sniok and removed request for skoeva and vyncent-t July 7, 2025 18:04
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look, a couple of things:

  • Have you tested this change / could you provide a screenshot of the fix in your PR? This is what I see on my end: image

  • Could you change the PR/commit title to the following format: <area>: <description of changes>

@blazethunderstorm
Copy link
Author

image
now its visible

@blazethunderstorm blazethunderstorm requested a review from skoeva July 9, 2025 14:09
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you now squash your changes and change the PR & commit titles as described?

For example, the title can be frontend: resourceMap: Unify network icon with sidebar

@blazethunderstorm
Copy link
Author

@skoeva sure , thanks for your review

@blazethunderstorm blazethunderstorm changed the title fix: unify network icon in resource map and sidebar frontend: resourceMap: Unify network icon with sidebar Jul 10, 2025
@blazethunderstorm
Copy link
Author

@skoeva cant the commits be sqaushed while merging ?

@blazethunderstorm blazethunderstorm requested a review from skoeva July 10, 2025 16:59
@blazethunderstorm
Copy link
Author

i am facing a bit of problem at my end

Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this comment: #3595 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Network" icon differs between sidebar and map filter
3 participants