-
Notifications
You must be signed in to change notification settings - Fork 497
Testing of all providers and distros #1605
Copy link
Copy link
Open
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem? Please describe.
We've had a few instances now where changes introduced issues into existing targets, e.g.
and most recently #1596 caused an issue for all OS's that made use of init data that wasn't caught during manual testing due to focussing on Flatcar.
Describe the solution you'd like
Where possible we should have automated tests in place to ensure that all currently supported providers and operating systems can build successfully with default values (this might be tricky in situations where there are required values).
This issue is aimed at tracking the progress of this effort and should be updated as progress is made.
Ideally, we should implement provider-specific tests that then build all OSs for that provider (e.g. using the
make build-raw-allthat should trigger all supported OSs).Progress
pull-azure-vhds&pull-azure-sigs. These make use ofci-azure-e2e.shbut uses a pre-defined list of target (azure_targets.sh). Ideally we should try to update this to dynamically load all targets we support.pull-image-builder-gcp-allthat usesci-gce.shbut this is currently configured as an optional test and not automatically run on any PRs. We should update this to at least trigger when changes to GCE files are made, similar to the Azure ones. (see #1601)pull-ova-allthat usesci-ova.shwhich currently has a static list of targets defined. We should update this to at least match our currently supported OSsDescribe alternatives you've considered
Manual testing but this, as we have seen, isn't enough to catch all the issues.
Additional context
Many of the providers will require actual cloud infrastructure to be able to run the build process. This is likely to be difficult to get unless the respective cloud providers are willing to donate resources for this purpose. (Please reach out to us if you are able to provide these resources)
/kind feature
/lifecycle frozen
/help
/priority important-longterm
/triage accepted