[Draft] Try to address the cloudbase init running order #1719
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
zylxjtu
changed the title
| export AZURE_LOCATION="uksouth" | ||
| export AZURE_CLIENT_ID="aa0caef4-31da-4426-9908-f75af27075c8" | ||
| export AZURE_SUBSCRIPTION_ID="1c8c4edc-b188-4199-9580-3173033d75f7" | ||
| export USE_AZURE_CLI_AUTH=true |
There was a problem hiding this comment.
you prob want to remove this file from the draft :)
| # If this file already exists then the following command fails | ||
| Remove-Item -Force {{ systemdrive.stdout | trim }}\Windows\Setup\Scripts\SetupComplete.cmd | ||
| & "{{ programfiles.stdout | trim }}\Cloudbase Solutions\Cloudbase-Init\bin\SetSetupComplete.cmd" | ||
| cmd /c sc config cloudbase-init depend= WindowsAzureGuestAgent start= auto |
There was a problem hiding this comment.
Whats the impact of this on non-Azure systems or providers?
| @@ -25,15 +25,17 @@ if( Test-Path $Env:SystemRoot\system32\Sysprep\unattend.xml ) { | |||
| Remove-Item $Env:SystemRoot\system32\Sysprep\unattend.xml -Force | |||
| } | |||
|
|
|||
| $unattendedXml = "$ENV:ProgramFiles\Cloudbase Solutions\Cloudbase-Init\conf\Unattend.xml" | |||
There was a problem hiding this comment.
Removal of this might break things. Might want to confirm this change
|
Could you elaborate a little bit more why it's needed? Is it specific for Azure? |
Change description
Related issues
Additional context