[WIP] Add config for constraining media pool#500
Draft
Bslabe123 wants to merge 1 commit into
Draft
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Bslabe123 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Bslabe123
force-pushed
the
media-pool
branch
2 times, most recently
from
5d81ef1 to
86425b4
Compare
k8s-ci-robot
added
size/XL
k8s-ci-robot
added
size/XXL
Introduces MediaPoolConfig{size} on the per-modality config so benchmarks
can express a bounded corpus of N distinct synthetic images / videos /
audios reused across requests. Pools are eagerly materialized at datagen
init and sampled uniformly.
Architecture follows the modality-primary scheme from kubernetes-sigs#477: each pool
lives in its own payloads/<modality>/pool.py alongside the modality's
spec and metrics, with a per-process singleton + set/get/reset helpers.
The pool_index field lives only on the Synthetic*Spec variants (the
provenance where bounded pre-rendering is meaningful), not on the bases
or non-synthetic provenances.
Prefix-side bytes still go through the existing seeded deterministic
path (pool is skipped when deterministic=True), so prefix-cache
benchmarks remain unaffected. Legacy mediagen.pool.VideoBytesPool stays
in place when no video.pool is configured.
Refs kubernetes-sigs#498.
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW