Spaces in directory path fails scaffolding - Create api

[The0mikkel]

What broke? What's expected?

When scaffolding an API with a path containing spaces, the create api command failed, while creating a mess of new directories.

Reproducing this issue

Do the following in a unix based system (I used Ubuntu)

mkdir -p "dir with spaces/operator"
cd "dir with spaces/operator"
kubebuilder init --domain com.example --repo demo
kubebuilder create api --group example --version v1 --kind Demo

Then say yes to Create Resource and Create Controller.

The scaffolding will then start but quickly fail with the following error:

ERROR CLI run failed error=error executing command: failed to create API: unable to run post-scaffold tasks of "base.go.kubebuilder.io/v4": error running make generate: error running "make": exit status 2

It creates a lot of directories, all over the place.

KubeBuilder (CLI) Version

4.9.0

PROJECT version

3

Plugin versions

Other versions

No response

Extra Labels

No response

[The0mikkel]

I have located a section of code, which may be where this happened:

kubebuilder/Makefile

Lines 30 to 32 in 12fb89d

	LOCALBIN ?= $(shell pwd)/bin
	$(LOCALBIN):
	mkdir -p $(LOCALBIN)

If the LOCALBIN variable has spaces, it will create multiple directories.

When looking at shell, a good source that descripes the issues is Shellcheck SC2086:
https://www.shellcheck.net/wiki/SC2086

[mayuka-c]

Let me try reproducing this locally.
@The0mikkel It might be due to this which you have mentioned :)

[mayuka-c]

/assign