✨ (go/v4): Improved conversion webhook implementation by adding default logic to copy ObjectMeta (name, namespace, labels, etc.). Included example usage for clarity.#4825
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom May 27, 2025
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
add-e2e-test
branch
3 times, most recently
from
1a7b915 to
13ce401
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
add-e2e-test
branch
from
13ce401 to
45a02ef
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
add-e2e-test
branch
from
45a02ef to
04b527e
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
… logic to copy ObjectMeta (name, namespace, labels, etc.). Included example usage for clarity.
camilamacedo86
force-pushed
the
add-e2e-test
branch
from
04b527e to
8f391cc
Compare
camilamacedo86
changed the title
Member
Author
|
Hi @robinlovell13 @sureshkrishnan-v @sbin64 Would you like to help with the review? |
Member
Author
|
It is too small |
camilamacedo86
added
the
lgtm
|
Cool! Thanks! @camilamacedo86 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: Enhance e2e Tests: Validate Conversion with Mock Scenario #4297