Skip to content

📖 fix examples how to specify watched CR in Watches()#4841

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jokuniew:watch-source-kind-doc-fix
May 30, 2025
Merged

📖 fix examples how to specify watched CR in Watches()#4841
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jokuniew:watch-source-kind-doc-fix

Conversation

@jokuniew
Copy link

I've followed the Kubebuilder book to add the Watches() method with predicates.
I'm using a project scaffolded with Kubebuilder v4.
I found that the examples didn't compile due to:
image

related bug: #3698

The last remaining place that uses source.Kind{} is migration guide from v0 to v1 (which does the opposite operation - it introduces the source.Kind)
https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/migration_guide.md?plain=1#L107-L108

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jokuniew / name: Julia Okuniewska (ea41c65)

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 30, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jokuniew!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jokuniew. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2025
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-totest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jokuniew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@camilamacedo86
Copy link
Member

You need to sign to CLA: #4841 (comment)

then we can move forward 🚀
thank you for your contirbution 🥇

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 30, 2025
@jokuniew
Copy link
Author

@camilamacedo86 I needed to double-check CLA options in my organization - it's all set now! 🚀

@k8s-ci-robot k8s-ci-robot merged commit 72a5ab5 into kubernetes-sigs:master May 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants