🌱 (CLI): Add unit tests and improve coverage for plugins/golang pkg#4959
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @mayuka-c. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| } else { | ||
| Expect(res.Path).To(Equal(path.Join(cfg.GetRepository(), "api", gvk.Version))) | ||
| } | ||
| } else if len(options.ExternalAPIPath) > 0 { |
There was a problem hiding this comment.
We might want to cover those options
To know more about see: https://kubebuilder.io/reference/using_an_external_resource
Also, you can check sample values in testdata samples like:
https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/PROJECT#L66C1-L79C14
There was a problem hiding this comment.
But we can do that in follow ups :-)
There was a problem hiding this comment.
Sure @camilamacedo86 I will take look into this :-)
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
/approved
Thank you so much for the nice contribution 🎉
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mayuka-c The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
Issue: #4925
Continuation from my previous UT PRs :-)