🐛 (AutoUpdate/v1-alpha): Adjust comments on Auto Update workflow#5082
🐛 (AutoUpdate/v1-alpha): Adjust comments on Auto Update workflow#5082k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Cool. For us to get merged, you need to run make generate so all samples and docs using it will be auto-updated. Can you please run it?
The comments for the `Run kubebuilder alpha update` step are now properly syntax-highlighted as such in yaml. The `--use-gh-models` flag is now properly referenced in the comments.
6365327 to
8090ded
Compare
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, vitorfloriano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request makes a minor adjustment to the Alpha Update workflow by moving comments up and correcting a flag name in the comments.
--open-gh-modelsto--use-gh-modelsin the comments aboveRun kubebuilder alpha updatestepRun kubebuilder alpha updatestep up just so the syntax is properly highlighted as a yaml commentBefore:
After: