🌱 Update test environment to Kubernetes 1.34 to match scaffolded projects#5157
🌱 Update test environment to Kubernetes 1.34 to match scaffolded projects#5157k8s-ci-robot merged 3 commits intomasterfrom
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This fixes the 404 error when fetching kubebuilder-tools by using Kubernetes 1.32.0 which is available in setup-envtest (release-0.20). The previous version v1.33.0 was too new and the corresponding kubebuilder-tools were not yet available. Co-authored-by: camilamacedo86 <7708031+camilamacedo86@users.noreply.github.com>
test/common.sh
Outdated
| fi | ||
|
|
||
| export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.33.0"}" | ||
| export KIND_K8S_VERSION="${KIND_K8S_VERSION:-"v1.32.0"}" |
There was a problem hiding this comment.
it should use the same verison used by go mod scaffolded
1.34
There was a problem hiding this comment.
@copilot see my comment
it should use the same verison used by go mod scaffolded
1.34.0
There was a problem hiding this comment.
Updated to use Kubernetes 1.34.0 to match the scaffolded go.mod (k8s.io/api v0.34.1). Also updated setup-envtest to release-0.22 to support k8s 1.34. Changes verified and working. Commit: 5d547cd
Updated KIND_K8S_VERSION from v1.32.0 to v1.34.0 and setup-envtest from release-0.20 to release-0.22 to align with the k8s.io/api v0.34.1 version used in testdata/project-v4/go.mod. This ensures the e2e tests use the same Kubernetes version as the scaffolded projects, maintaining consistency across the codebase. Co-authored-by: camilamacedo86 <7708031+camilamacedo86@users.noreply.github.com>
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubebuilder-e2e-k8s-1-33-0 |
make test-e2e-localfails with 404 when fetching kubebuilder-tools because the test environment was using a different Kubernetes version than the scaffolded projects.Changes
KIND_K8S_VERSIONfromv1.33.0tov1.34.0intest/common.shto match the k8s.io/api v0.34.1 used in scaffolded projectssetup-envtestfromrelease-0.20torelease-0.22to support Kubernetes 1.34This ensures the e2e test environment uses the same Kubernetes version as the scaffolded projects (testdata/project-v4/go.mod), maintaining consistency across the codebase.
Version 1.34.0 is supported by controller-runtime release-0.22 and has available tooling in the setup-envtest GCS bucket.
Addresses #4082
Fixes #4515
Original prompt
This section details on the original issue you should resolve
<issue_title>make test-e2e-local fails</issue_title>
<issue_description>
Issue Description
When running make test-e2e-local, the script fails with a 404 Not Found error while attempting to fetch kubebuilder-tools-1.31.0-linux-amd64.tar.gz from Google Cloud Storage (GCS).
</issue_description>
<agent_instructions># AGENTS.md
Kubebuilder
Project Overview
Kubebuilder is a framework and command-line interface (CLI) for building Kubernetes APIs using Custom Resource Definitions (CRDs).
It provides scaffolding and abstractions that accelerate the development of controllers, webhooks, and APIs written in Go.
sigs.k8s.io/kubebuilder/v4(requires Go ≥1.25)controller-runtime,controller-toolsCore Components
controller-runtime
controller-tools
make generate,make manifests, etc.Extensibility and Integrations
Architecture
pkg/plugins/golang/v4— scaffolds Go projectspkg/plugins/common/kustomize/v2— scaffolds theconfig/dir using Kustomizepkg/plugins/helm/v2-alpha— Helm-based operatorspkg/plugins/deploy-image— container image supportpkg/plugins/autoupdate/v1-alpha— upgrade automationRepository Layout
cmd/pkg/plugins/pkg/cli,pkg/machinery,pkg/model,pkg/internalhack/docs/generate.sh)docs/book/testdata/test/e2e/,features.sh)designs/roadmap/Build & Test Commands
Build Kubebuilder
Lint & Style Checks
# Validate and fix code style issues make lint-fixTesting Instructions
Pre-requisites
To run tests under
test/you need:Cluster setup
Ensure
kubectl config current-contextpoints tokind-kindbefore running tests.Running e2e tests
The test suite includes both:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.