🐛 fix(api): move package cmd to internal#5400
Merged
camilamacedo86 merged 1 commit intokubernetes-sigs:masterfrom Jan 27, 2026
Merged
🐛 fix(api): move package cmd to internal#5400camilamacedo86 merged 1 commit intokubernetes-sigs:masterfrom
camilamacedo86 merged 1 commit intokubernetes-sigs:masterfrom
Conversation
The cmd package is now for internal usage only, cleaning up the Kubebuilder library API. The Run() function in package cmd is not well-documented and is not meant to be used by external users.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
Contributor
Author
|
/retest |
Member
|
It seems fine. |
camilamacedo86
merged commit 1933691
into
kubernetes-sigs:master
15 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
cmdpackage to internal.The
cmdpackage is not documented and should not be used by external users.See: https://pkg.go.dev/sigs.k8s.io/kubebuilder/v4@v4.11.0/cmd
Also, we should note that the
cmdpackage has only one function that is only imported by the main function inmain.goin root.We decided not to simply move the logic in
Run()tomain.goto give us more flexibility when writing tests in the future.