🐛 fix(helm/v2-alpha): Replace bitnami/kubectl:latest with busybox:1.37#5476
Closed
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:masterfrom
Closed
🐛 fix(helm/v2-alpha): Replace bitnami/kubectl:latest with busybox:1.37#5476camilamacedo86 wants to merge 1 commit intokubernetes-sigs:masterfrom
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
Contributor
|
New changes are detected. LGTM label has been removed. |
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
bd3e11a to
74a38b7
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
74a38b7 to
0a958e1
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
0a958e1 to
96aa763
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
added
do-not-merge/work-in-progress
Member
Author
|
We cannot release without change the image for a image that we can trust in long term. |
camilamacedo86
added
the
lgtm
camilamacedo86
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
96aa763 to
b936d2f
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
2 times, most recently
from
6998a03 to
0270688
Compare
k8s-ci-robot
removed
the
size/M
k8s-ci-robot
added
the
size/L
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
2 times, most recently
from
93a1a80 to
ff35fb8
Compare
camilamacedo86
changed the title
bitnami/kubectl:latest with registry.k8s.io/busybox:1.27.2 + runtime kubectl download from official Kubernetes releases.
camilamacedo86
changed the title
bitnami/kubectl:latest with registry.k8s.io/busybox:1.27.2 + runtime kubectl download from official Kubernetes releases.
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
ff35fb8 to
c55bf2a
Compare
camilamacedo86
changed the title
Contributor
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
c55bf2a to
6420eff
Compare
…mage and allow to config Co-authored-by: Cursor <cursoragent@cursor.com>
camilamacedo86
force-pushed
the
fix-image-testcharts
branch
from
6420eff to
8f8e15e
Compare
Member
Author
|
Close we will need to revert this addition to the plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
bitnami/kubectl:latestwithbusybox:1.37+ runtime kubectl download from official Kubernetes releases (dl.k8s.io).Problem
The current Helm chart tests use
bitnami/kubectl:latest, which has several issues::latesttag breaks reproducibilityInvestigation: Why Not Use registry.k8s.io Images?
We thoroughly investigated using only official Kubernetes registry images:
Option 1:
registry.k8s.io/kubectl:v1.35.0❌ No shell - Image contains only the kubectl binary, cannot run test scripts that require
/bin/shOption 2:
registry.k8s.io/busybox:1.27.2❌ Outdated TLS - From 2017, uses old SSL/TLS libraries that fail to download from modern HTTPS endpoints