WIP 🐛 fix(API): Move autoupdate/deploy-image/helm packages to internal

[vitorfloriano]

This PR moves the packages for the optional plugins autoupdate, deploy-image and helm to ./internal/plugins/optional.

Those optional plugins are meant only for CLI users and their packages should not be part of the public API of the SDK, considering that they are underdocumented and not stable, hence they belong in internal.

Here's a summary of the current situation of each plugin:

package	no known importers
autoupdate/v1alpha	import stats
autoupdate/v1alpha/scaffolds	import stats
deploy-image/v1alpha	import stats
deploy-imagem/v1alpha/scaffolds	import stats
helm/v1alpha	import stats
helm/v1alpha/scaffolds	import stats
helm/v2alpha	import stats
helm/v2alpha/scaffolds	import stats

Important

We are not moving the grafana plugin because it has already been imported by Operator SDK, as per the import stats on pkg.go.dev and this search result.

---

The project structure will go from this:

├── pkg
│   └── plugins
│       ├── common
│       ├── external
│       ├── golang
│       │   ├── deploy-image   <--- in the public API
│       │   └── v4
│       └── optional
│           ├── autoupdate     <--- in the public API
│           ├── grafana        <--- already imported by Operator-SDK
│           └── helm           <--- in the public API

To this:

├── internal
│   ├── cli
│   ├── logging
│   └── plugins
│       └── optional
│           ├── autoupdate
│           ├── deploy-image
│           └── helm
├── pkg
│   └── plugins
│       ├── common
│       ├── external
│       ├── golang
│       └── optional
│           └── grafana

---

Note

We also moved the deploy-image plugin from pkg/plugins/go/ to ./internal/plugins/optional for consistency.

Related to: #5277 (comment)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@vitorfloriano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-test	02c686c	link	true	/test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vitorfloriano]

@camilamacedo86 I just realized we have a lot of PRs touching the Helm plugin.

I'll revert the changes so we don't mess the other PRs up.

[vitorfloriano]

@camilamacedo86 Thinking better, the scope of this PR is too broad and touching too many parts. I also just found out that I had overlooked the fact that deploy-image is also imported by Operator-SDK.

I still think we need to move some packages to internal, but it's better to do it incrementally, package by package, to minimize surprises.

So I'm closing this one. Sorry about the noise.