replace features.SetEnable with featuregatetesting.SetFeatureGateDuringTest#9595
replace features.SetEnable with featuregatetesting.SetFeatureGateDuringTest#9595AwsAqh wants to merge 10 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
Welcome @AwsAqh! |
k8s-ci-robot
added
cncf-cla: no
|
Hi @AwsAqh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
release-note-none
| ginkgo.AfterAll(func() { | ||
| managerTestCluster.fwk.StopManager(managerTestCluster.ctx) | ||
| gomega.Expect(features.SetEnable(features.DynamicResourceAllocation, false)).To(gomega.Succeed()) | ||
|
|
There was a problem hiding this comment.
Please remove this line.
| package multikueue | ||
|
|
||
| import ( | ||
| featuregatetesting "k8s.io/component-base/featuregate/testing" |
There was a problem hiding this comment.
Please execute make lint-fix to fix imports.
| utiltestingapi "sigs.k8s.io/kueue/pkg/util/testing/v1beta2" | ||
| testingjob "sigs.k8s.io/kueue/pkg/util/testingjobs/job" | ||
| "sigs.k8s.io/kueue/test/util" | ||
|
|
There was a problem hiding this comment.
Please remove this line.
| featuregatetesting.SetFeatureGateDuringTest( | ||
| ginkgo.GinkgoT(), | ||
| utilfeature.DefaultFeatureGate, | ||
| features.TASBalancedPlacement, | ||
| true, | ||
| ) |
There was a problem hiding this comment.
| featuregatetesting.SetFeatureGateDuringTest( | |
| ginkgo.GinkgoT(), | |
| utilfeature.DefaultFeatureGate, | |
| features.TASBalancedPlacement, | |
| true, | |
| ) | |
| features.SetFeatureGateDuringTest(ginkgo.GinkgoT(), features.DynamicResourceAllocation, true) |
Let's try this one.
There was a problem hiding this comment.
Updated - switched to features.SetFeatureGateDuringTest(...) as suggested (and applied the same pattern across the other test files in this PR). Thanks!
| ) | ||
|
|
||
| ginkgo.BeforeAll(func() { | ||
| gomega.Expect(features.SetEnable(features.DynamicResourceAllocation, true)).To(gomega.Succeed()) |
There was a problem hiding this comment.
I think this function no need anymore. Can we delete it?
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AwsAqh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AwsAqh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?