Skip to content

Refactor featuregate setup in tests to reduce possibility of flaky tests conflicts#9600

Open
0xlen wants to merge 3 commits intokubernetes-sigs:mainfrom
0xlen:main
Open

Refactor featuregate setup in tests to reduce possibility of flaky tests conflicts#9600
0xlen wants to merge 3 commits intokubernetes-sigs:mainfrom
0xlen:main

Conversation

@0xlen
Copy link

@0xlen 0xlen commented Mar 1, 2026

What type of PR is this?

/kind cleanup
/area testing

What this PR does / why we need it:

This PR updates integration tests to use features.SetFeatureGateDuringTest(...) instead of features.SetEnable(...) for the following feature gates:

  • DynamicResourceAllocation
  • AdmissionFairSharing
  • TASBalancedPlacement

In dra_test.go, move DRA gate setup from BeforeAll to BeforeEach to scope gate lifecycle per-spec and avoid feature-gate parallel cleanup conflicts.

Why this is needed

Using SetEnable in integration tests can leak feature-gate state across tests and contribute to flakiness.
SetFeatureGateDuringTest binds feature-gate mutation to test lifecycle and restores state automatically, improving test isolation.

Additionally, in multikueue/dra_test.go, moving gate setup to BeforeEach avoids potential parallel gate cleanup collisions observed during validation.

Which issue(s) this PR fixes:

Fixes #9594

Does this PR introduce a user-facing change?

NONE

@0xlen
Refactor feature gate setup in tests to use SetFeatureGateDuringTest …
6140408 
…for DynamicResourceAllocation, AdmissionFairSharing, and TASBalancedPlacement
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Testing - related stuff labels Mar 1, 2026
@netlify
Copy link

netlify bot commented Mar 1, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit cec3b3f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69a48e6709e4d400089095bd

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2026

Welcome @0xlen!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 1, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2026

Hi @0xlen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2026
@0xlen 0xlen changed the title Refactor feature gate setup in tests to reduce possibility of flaky tests upon featuregates conflicts Refactor feature gate setup in tests to reduce possibility of flaky tests conflicts Mar 1, 2026
@0xlen 0xlen changed the title Refactor feature gate setup in tests to reduce possibility of flaky tests conflicts Refactor featuregate setup in tests to reduce possibility of flaky tests conflicts Mar 1, 2026
@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Mar 1, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 1, 2026
mbobrovskyi
mbobrovskyi reviewed Mar 1, 2026
View reviewed changes
test/integration/multikueue/dra_test.go
)

ginkgo.BeforeAll(func() {
gomega.Expect(features.SetEnable(features.DynamicResourceAllocation, true)).To(gomega.Succeed())
Copy link
Contributor

@mbobrovskyi mbobrovskyi Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove features.SetEnable()? It looks like it’s no longer used.

Copy link
Author

@0xlen 0xlen Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mbobrovskyi - I didn't find any other references for SetEnable . Remove them and verified in test after removing in the latest commit.

mbobrovskyi
mbobrovskyi reviewed Mar 1, 2026
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0xlen
Once this PR has been reviewed and has the lgtm label, please assign gabesaba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@0xlen 0xlen requested a review from mbobrovskyi March 1, 2026 19:08
@0xlen 0xlen marked this pull request as ready for review March 1, 2026 19:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2026
@k8s-ci-robot k8s-ci-robot requested a review from pajakd March 1, 2026 19:08
@Huang-Wei
Copy link
Contributor

Huang-Wei commented Mar 2, 2026

@0xlen could you sync the changes (I just did that for testing and will close to favor this PR) from #9603 here? so reviewers can unify their reviews in one PR. Later I will close #9603

@Huang-Wei Huang-Wei mentioned this pull request Mar 2, 2026
Closed
@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Mar 2, 2026

@0xlen could you sync the changes (I just did that for testing and will close to favor this PR) from #9603 here? so reviewers can unify their reviews in one PR. Later I will close #9603

@0xlen, yes, please apply this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@pajakd pajakd Awaiting requested review from pajakd

Assignees

No one assigned

Labels

area/testing Testing - related stuff cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Eliminate using features.SetEnable() in tests

4 participants

@0xlen @k8s-ci-robot @mbobrovskyi @Huang-Wei