Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

fix(plugins/plugin-s3): ibm s3 provider fails with cross-region endpo… #7686

Merged
merged 1 commit into from
Jun 23, 2021
Merged

fix(plugins/plugin-s3): ibm s3 provider fails with cross-region endpo… #7686

merged 1 commit into from
Jun 23, 2021

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Jun 22, 2021 •
edited
Loading

…ints

Fixes #7685

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot requested a review from mark-nc June 22, 2021 23:21
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from myan9 June 22, 2021 23:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2021
@myan9
Copy link
Contributor

myan9 commented Jun 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 291ee71 into kubernetes-retired:master Jun 23, 2021
@starpit starpit deleted the fix-7685 branch June 23, 2021 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mark-nc mark-nc Awaiting requested review from mark-nc

@myan9 myan9 Awaiting requested review from myan9

Assignees

@myan9 myan9

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ibm s3 provider does not support cross-region endpoints

3 participants

@starpit @k8s-ci-robot @myan9