Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@mra-ruiz
Copy link
Contributor

@mra-ruiz mra-ruiz commented Aug 11, 2021

Fixes #7490
Updated how search bar looks using PatternFly and updated tests.

@mra-ruiz mra-ruiz requested a review from starpit as a code owner August 11, 2021 20:33
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from mark-nc and myan9 August 11, 2021 20:33
@mra-ruiz
Copy link
Contributor Author

/assign @starpit

@starpit
Copy link
Contributor

starpit commented Aug 11, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mra-ruiz, starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 29f5f43 into kubernetes-retired:master Aug 11, 2021
@mra-ruiz mra-ruiz deleted the searchbar branch August 11, 2021 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

find-in-page stripe doesn't have much contrast

3 participants