Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

fix(plugins/plugin-core-support): ReadOnly clients cannot toggle edit… #8154

Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix(plugins/plugin-core-support): ReadOnly clients cannot toggle edit… #8154

merged 1 commit into from
Oct 11, 2021

Conversation

@mra-ruiz
Copy link
Contributor

… mode

Fixes #8149

Description of what you did:

Disabled the ability for clients with read only permissions to toggle edit mode

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@mra-ruiz mra-ruiz requested a review from starpit as a code owner October 11, 2021 20:28
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from mark-nc and myan9 October 11, 2021 20:28
@mra-ruiz
Copy link
Contributor Author

/assign @starpit

@starpit
Copy link
Contributor

starpit commented Oct 11, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mra-ruiz, starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 668d0e5 into kubernetes-retired:master Oct 11, 2021
@starpit starpit mentioned this pull request Oct 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@starpit starpit Awaiting requested review from starpit

@mark-nc mark-nc Awaiting requested review from mark-nc

@myan9 myan9 Awaiting requested review from myan9

Assignees

@starpit starpit

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toggle Edit Mode menu item should not be displayed for offline or readonly clients?

3 participants

@mra-ruiz @starpit @k8s-ci-robot