This repository was archived by the owner on Jul 30, 2025. It is now read-only.
11.1.2 #8515
Merged
11.1.2 #8515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e visible in offline clients
…rd mini step oddly moves elements the connector between progress steps shifts down. this is due to some stock patternfly rules overriding ours
This PR adds a `--snippet-base-path` option to `replay` and `commentary` commands. It also for now assumes a default snippet path of one of: - ./ - ../ - ../snippets - ../../snippets
…nize elements after "bug"
…xt near tab title
…use internal exception e.g. ```markdown ```
…ndefined" in the UI
…e empty header UI
…cified in topmatter
for markdown, e.g.
---
snippets:
basePath: https://raw.githubusercontent.com/knative/docs/main/docs/snippets
---
renders as blank if there are not steps, but still plenty of content or if we only have a title but no steps
We had required a code block id attribute in order for code block validation to function. We can assign one for the user, if not specified. Also, the validation logic did not re-fire after a source update e.g. in the playground. Fixed Also added types to the code-indexer rehype plugin.
… full urls or recursive inclusion
k8s-ci-robot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picks from master into 11_1_x:
[11.1.2 3fc0de5] fix(plugins/plugin-client-common): yet more tweaks to wizard nav width
Date: Tue Jan 25 10:09:11 2022 -0500
1 file changed, 2 insertions(+), 2 deletions(-)
[11.1.2 dfd6b7a] doc: add sample input/output for iter8 guidebook
Date: Tue Jan 25 10:14:59 2022 -0500
3 files changed, 8 insertions(+), 6 deletions(-)
create mode 100644 plugins/plugin-iter8/notebooks/tutorial1.json
[11.1.2 3776e93] fix(plugins/plugin-client-common): sigh more tweaks to wizard nav width
Date: Tue Jan 25 10:43:15 2022 -0500
1 file changed, 2 insertions(+), 2 deletions(-)
[11.1.2 5bbc9cd] fix(plugins/plugin-client-common): code block run button should not be visible in offline clients
Date: Tue Jan 25 10:57:27 2022 -0500
1 file changed, 6 insertions(+), 6 deletions(-)
[11.1.2 d2067b3] fix(plugins/plugin-client-common): in some browsers, hovering in wizard mini step oddly moves elements
Date: Tue Jan 25 13:29:29 2022 -0500
1 file changed, 1 insertion(+)
[11.1.2 4c756e7] feat: initial support for snippets (hash include) in markdown
Date: Tue Jan 25 14:52:24 2022 -0500
13 files changed, 304 insertions(+), 40 deletions(-)
create mode 100644 plugins/plugin-client-common/src/controller/snippets.ts
create mode 100644 plugins/plugin-client-common/src/test/core/snippets-in-markdown.ts
create mode 100644 plugins/plugin-client-common/tests/data/snippet1.md
create mode 100644 plugins/plugin-client-common/tests/data/snippet2.md
create mode 100644 plugins/plugin-client-common/tests/data/snippet3.md
create mode 100644 plugins/plugin-client-common/tests/data/snippeta.md
create mode 100644 plugins/plugin-client-common/tests/data/snippetb.md
create mode 100644 plugins/plugin-client-common/tests/data/snippetc.md
[11.1.2 fb743de] fix(plugins/plugin-client-common): markdown tip parsing may not recognize elements after "bug"
Date: Tue Jan 25 19:51:58 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.2 417009c] fix(plugins/plugin-client-common): markdown tabs may drop/misplace text near tab title
Date: Tue Jan 25 20:18:12 2022 -0500
2 files changed, 14 insertions(+), 5 deletions(-)
[11.1.2 f1857af] fix(plugins/plugin-client-common): blank heading lines in markdown cause internal exception
Date: Tue Jan 25 20:58:29 2022 -0500
2 files changed, 6 insertions(+), 2 deletions(-)
[11.1.2 b6d0732] fix: color contrast fixes for Sidebar and Wizard header
Date: Tue Jan 25 21:25:41 2022 -0500
7 files changed, 51 insertions(+), 105 deletions(-)
copy plugins/plugin-core-themes/web/scss/{dark.scss => dark-mixins.scss} (92%)
rewrite plugins/plugin-core-themes/web/scss/dark.scss (73%)
[11.1.2 929b886] fix(plugins/plugin-client-common): wizards with no title render as "undefined" in the UI
Date: Tue Jan 25 22:07:23 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.2 0f93f66] fix(plugins/plugin-client-common): wizards with emtpy 1st section have empty header UI
Date: Wed Jan 26 10:09:54 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.2 8db5a86] fix(plugins/plugin-client-common): replay filepaths with spaces
Date: Wed Jan 26 10:17:17 2022 -0500
1 file changed, 1 insertion(+), 1 deletion(-)
[11.1.2 dcfc5df] feat(plugins/plugin-client-common): allow snippet base path to be specified in topmatter
Date: Wed Jan 26 10:38:19 2022 -0500
1 file changed, 46 insertions(+), 24 deletions(-)
[11.1.2 051b2bb] fix(plugins/plugin-client-common): wizard behaves poorly when empty
Date: Wed Jan 26 11:42:13 2022 -0500
2 files changed, 2 insertions(+), 2 deletions(-)
[11.1.2 01c2298] fix(plugins/plugin-client-common): more nav width tweaks
Date: Wed Jan 26 12:06:25 2022 -0500
1 file changed, 3 insertions(+), 3 deletions(-)
[11.1.2 5596886] fix(plugins/plugin-client-common): code blocks with validate: true do not validate
Date: Wed Jan 26 12:08:01 2022 -0500
1 file changed, 3 insertions(+), 1 deletion(-)
[11.1.2 2b51d6a] fix(plugins/plugin-client-common): allow code block id to be optional
Date: Wed Jan 26 12:38:09 2022 -0500
5 files changed, 74 insertions(+), 45 deletions(-)
[11.1.2 453d343] doc: remove code block ids from notebooks where no longer needed
Date: Wed Jan 26 14:13:24 2022 -0500
3 files changed, 9 deletions(-)
[11.1.2 9d6ad8b] fix(plugins/plugin-client-common): snippet inclusion does not support full urls or recursive inclusion
Date: Wed Jan 26 15:05:24 2022 -0500
3 files changed, 56 insertions(+), 27 deletions(-)
create mode 100644 plugins/plugin-client-common/tests/data/snippet-via-url.md