This repository was archived by the owner on Jul 30, 2025. It is now read-only.
11.2.4 #8636
Merged
11.2.4 #8636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r effect also, the tooltips are oddly positioned
…th trailing whitespace
…inks For cases where we have no basePath. This PR also improves the presentation of snippet inlining failures, using a "bug" expandable section to convey the error message to the user.
… and already-executed code blocks
…or validated code blocks
…cution order This PR also changes the play icon from circle-play to plain play
…ients with sample output Right now, we always hide the Run button for code blocks if offline clients. We do this, even if we have sample output. This PR adjusts this behavior so that we do show the Run button in this situation, but treat "running" as merely showing the sample output.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[11.2.4 1330e3a] fix(plugins/plugin-client-common): wizard mini progress UI lacks hover effect
Date: Wed Feb 9 19:46:39 2022 -0500
2 files changed, 21 insertions(+), 7 deletions(-)
[11.2.4 12e0ce1] fix(plugins/plugin-client-common): snippet inliner fails for lines with trailing whitespace
Date: Thu Feb 10 11:32:56 2022 -0500
2 files changed, 4 insertions(+), 2 deletions(-)
[11.2.4 fba4115] fix(plugins/plugin-client-common): snippet inliner fails in reroute links
Date: Thu Feb 10 12:12:59 2022 -0500
1 file changed, 43 insertions(+), 28 deletions(-)
[11.2.4 715729c] feat(plugins/plugin-client-common): initial support for code block ordering
Date: Thu Feb 10 11:46:40 2022 -0500
20 files changed, 666 insertions(+), 122 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/components/code/README.md
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/components/code/dump.ts
create mode 100644 plugins/plugin-client-common/src/components/Content/Markdown/components/code/graph.ts
[11.2.4 2e4fa5a] feat(plugins/plugin-client-common): more clearly distinguish optional and already-executed code blocks
Date: Sat Feb 12 12:48:24 2022 -0500
6 files changed, 113 insertions(+), 32 deletions(-)
[11.2.4 a4e9c28] fix(plugins/plugin-client-common): hide except on hover play button for validated code blocks
Date: Sat Feb 12 13:25:23 2022 -0500
8 files changed, 80 insertions(+), 12 deletions(-)
create mode 100644 plugins/plugin-client-common/web/scss/components/Tooltip/_mixins.scss
[11.2.4 b75ffbf] feat(plugins/plugin-client-common): assign code blocks an ordinal execution order
Date: Sat Feb 12 20:23:24 2022 -0500
13 files changed, 452 insertions(+), 144 deletions(-)
create mode 100644 plugins/plugin-client-common/src/components/Views/Terminal/Block/CodeBlockEvents.ts
create mode 100644 plugins/plugin-client-common/tests/data/wizard-steps-in-topmatter2.md
[11.2.4 dbf8877] feat(plugins/plugin-client-common): show code block Run in offline clients with sample output
Date: Mon Feb 14 09:57:06 2022 -0500
2 files changed, 50 insertions(+), 26 deletions(-)