This repository was archived by the owner on Jul 30, 2025. It is now read-only.
fix: sigh, npm 8.3.1 (node 16.14.0) broke our colors override #8638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems like a bug in npm, as we have a dependence pinned on 1.4.0, and an override specified also to pin 1.4.0 of colors, but `npm ci` with 16.14.0 complains about some non-existent conflict. the fix seems to be to use `$colors` rather than `1.4.0` in the override declaration
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like a bug in npm, as we have a dependence pinned on 1.4.0, and an override specified also to pin 1.4.0 of colors, but
npm ciwith 16.14.0 complains about some non-existent conflict.the fix seems to be to use
$colorsrather than1.4.0in the override declarationDescription of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs