This repository was archived by the owner on Jul 30, 2025. It is now read-only.
feat: improve consistency of input element coloring between guidebook… #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
starpit
force-pushed
the
inverted-colors-for-prompt
branch
4 times, most recently
from
a1cfc5d to
163c542
Compare
k8s-ci-robot
added
size/L
starpit
force-pushed
the
inverted-colors-for-prompt
branch
4 times, most recently
from
39dd56b to
abca721
Compare
k8s-ci-robot
added
size/M
starpit
force-pushed
the
inverted-colors-for-prompt
branch
from
abca721 to
4f441be
Compare
k8s-ci-robot
added
size/L
starpit
force-pushed
the
inverted-colors-for-prompt
branch
2 times, most recently
from
dd0c0f0 to
ea24eee
Compare
…s and plain terminals Guidebooks use an inverted color scheme for input elements, but the plain terminal does not. This PR updates plain terminals, in light themes, to do so, too.
starpit
force-pushed
the
inverted-colors-for-prompt
branch
from
ea24eee to
4a8997c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and plain terminals
Guidebooks use an inverted color scheme for input elements, but the plain terminal does not. This PR updates plain terminals, in light themes, to do so, too.
Proposal
Current Design
Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs