Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Feb 16, 2022

…d be consistent in UI

The UI for drilling down to related resources is typically to have a "Show X" button at the bottom of the sidecar. But for the pods of a deployment, we are still using a Tab UI.

This PR updates the drilldown mode to be consistent with the dominant UI scheme.
Screen Shot 2022-02-16 at 4 22 34 PM

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 16, 2022
…d be consistent in UI

The UI for drilling down to related resources is typically to have a "Show X" button at the bottom of the sidecar. But for the pods of a deployment, we are still using a Tab UI.

This PR updates the drilldown mode to be consistent with the dominant UI scheme.
@starpit starpit force-pushed the deploy-pod-drilldown branch from e8649ff to f86c139 Compare February 16, 2022 21:53
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2022
@starpit starpit merged commit bdf6eb5 into kubernetes-retired:master Feb 16, 2022
@starpit starpit deleted the deploy-pod-drilldown branch February 16, 2022 22:57
@starpit starpit changed the title fix(plugins/plugin-client-common): Deployment-to-Pods drilldown shoul… fix(plugins/plugin-kubectl): Deployment-to-Pods drilldown shoul… Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants