This repository was archived by the owner on Jul 30, 2025. It is now read-only.
feat: allow guidebooks to capture prefetched row drilldown content #8683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replaying a guidebook in an offline client (e.g. in a static single page web app), you may still want to allow users of that guidebook to experience drilling down from tables. This PR enables this by default on save: every code block response that is a table will have its rows prefetched, at least for those rows that indicate `onclickIdempotent: true`. This PR adds a feature to `execOptions` called `masquerade` which allows one controller to invoke another, but to have that command appear in the UI as something else. For this use case, the masquerade feature allows us to register a single `replay-content` command, but to have it appear to the guidebook user as if that command were the original drilldown command.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replaying a guidebook in an offline client (e.g. in a static single page web app), you may still want to allow users of that guidebook to experience drilling down from tables. This PR enables this by default on save: every code block response that is a table will have its rows prefetched, at least for those rows that indicate
onclickIdempotent: true.This PR adds a feature to
execOptionscalledmasqueradewhich allows one controller to invoke another, but to have that command appear in the UI as something else. For this use case, the masquerade feature allows us to register a singlereplay-contentcommand, but to have it appear to the guidebook user as if that command were the original drilldown command.Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs