This repository was archived by the owner on Jul 30, 2025. It is now read-only.
feat: allow for guidebooks to have a "normal" split with a terminal #8691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
starpit
force-pushed
the
terminals-in-markdown
branch
2 times, most recently
from
150e6af to
43be2c7
Compare
Right now, guidebooks can only have markdown content in splits. Some use cases would benefit from having one of their splits be a normal terminal.
This PR adds a `terminal` option to the guidebook topmatter, e.g. (from terminal1.md test input) this guidebook would have the first split offer a normal terminal interaction, and the second split be markdown only, without a normal terminal interaction (which is the default behavior for splits in guidebooks, hence the `2: default`)
New splits can also now have inverted colors. See terminal3.md for an example.
```markdown
---
layout:
1: terminal
2: default
---
XXXX
---
YYYY
```
starpit
force-pushed
the
terminals-in-markdown
branch
from
43be2c7 to
80cb571
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, guidebooks can only have markdown content in splits. Some use cases would benefit from having one of their splits be a normal terminal.
This PR adds a
terminaloption to the guidebook topmatter, e.g. (from terminal1.md test input) this guidebook would have the first split offer a normal terminal interaction, and the second split be markdown only, without a normal terminal interaction (which is the default behavior for splits in guidebooks, hence the2: default)Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs