Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

fix(plugins/plugin-client-common): Tooltip component can present empt… #8732

Merged
merged 1 commit into from
Feb 28, 2022
Merged

fix(plugins/plugin-client-common): Tooltip component can present empt… #8732

merged 1 commit into from
Feb 28, 2022

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Feb 28, 2022 •
edited
Loading

…y tooltip

We should guard against empty content. The MadeWithKui widget is an example.

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@starpit
fix(plugins/plugin-client-common): Tooltip component can present empt…
0bb1466 
…y tooltip

We should guard against empty content. The MadeWithKui widget is an example.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@starpit starpit merged commit f9850d8 into kubernetes-retired:master Feb 28, 2022
@starpit starpit deleted the empty-tooltip branch February 28, 2022 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mark-nc mark-nc Awaiting requested review from mark-nc

@myan9 myan9 Awaiting requested review from myan9

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@starpit @k8s-ci-robot