Skip to content

feat(controller): create prerequisites from annotation#227

Open
rdwj wants to merge 2 commits into
kubernetes-sigs:mainfrom
rdwj:feat/auto-create-prerequisites
Open

feat(controller): create prerequisites from annotation#227
rdwj wants to merge 2 commits into
kubernetes-sigs:mainfrom
rdwj:feat/auto-create-prerequisites

Conversation

@rdwj
Copy link
Copy Markdown

@rdwj rdwj commented Jun 4, 2026

Summary

When the annotation mcp.x-k8s.io/auto-create-prerequisites is set to "true" on an MCPServer CR, the operator creates missing ServiceAccounts and ConfigMaps before validation. Resources are owned by the MCPServer and cleaned up on deletion.

Motivation

Deploying MCP servers from the RHOAI catalog requires manually creating ServiceAccounts and ConfigMaps per namespace before the MCPServer CR will reconcile. This annotation-gated feature automates that step for catalog-based deployments.

Addresses #226

Changes

  • New file: internal/controller/mcpserver_controller_prerequisites.goensurePrerequisites() function
  • Modified: internal/controller/mcpserver_controller.go — call ensurePrerequisites() before validation, updated RBAC markers
  • Updated: config/rbac/role.yaml — added list, watch, and create verbs for serviceaccounts
  • Tests: internal/controller/mcpserver_controller_prerequisites_test.go — 7 test cases covering annotation gating, resource creation, idempotency, and owner references

Testing

Validated on a live RHOAI 3.4 / OpenShift 4.20 cluster:

  • With annotation: ServiceAccount and ConfigMap auto-created, MCPServer reconciled to Running
  • Without annotation: no resources created, MCPServer correctly reported Failed with missing ConfigMap error
  • All existing unit tests pass (make test)
  • Lint clean (make lint)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 4, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 4, 2026

Deploy Preview for mcp-lifecycle-operator ready!

Name Link
🔨 Latest commit 9c3cbfe
🔍 Latest deploy log https://app.netlify.com/projects/mcp-lifecycle-operator/deploys/6a20fa6f484128000858370e
😎 Deploy Preview https://deploy-preview-227--mcp-lifecycle-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rdwj
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 4, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: rdwj / name: rdwj (d7cb3fc)

@k8s-ci-robot k8s-ci-robot requested review from matzew and soltysh June 4, 2026 03:43
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @rdwj!

It looks like this is your first PR to kubernetes-sigs/mcp-lifecycle-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/mcp-lifecycle-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @rdwj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2026
rdwj added 2 commits June 3, 2026 23:09
When the annotation mcp.x-k8s.io/auto-create-prerequisites is set to
"true", the operator creates missing ServiceAccounts and ConfigMaps
referenced by the MCPServer CR before validation. Resources are owned
by the MCPServer so they are cleaned up on deletion.

Related: kubernetes-sigs#226
Controller-runtime's client cache requires list and watch permissions
to set up informers. Without them, the ensurePrerequisites function
cannot check ServiceAccount existence.
@rdwj rdwj force-pushed the feat/auto-create-prerequisites branch from d7cb3fc to 9c3cbfe Compare June 4, 2026 04:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants