Enhance MCPServer with emptyDir#62
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
24bfa92 to
bddee7e
Compare
bddee7e to
1ca212b
Compare
Signed-off-by: Ali Ok <aliok@redhat.com>
1ca212b to
1540d38
Compare
|
cc @matzew this is now rebased. |
| source: | ||
| type: ContainerImage | ||
| containerImage: | ||
| ref: docker.io/library/nginx:latest |
There was a problem hiding this comment.
nope - let's please use real servers
There was a problem hiding this comment.
There was a problem hiding this comment.
apiVersion: mcp.x-k8s.io/v1alpha1
kind: MCPServer
metadata:
name: kubernetes-mcp-server
spec:
source:
type: ContainerImage
containerImage:
ref: quay.io/containers/kubernetes_mcp_server:latest
config:
port: 8080
storage:
- path: /tmp
permissions: ReadWrite
source:
type: EmptyDir
emptyDir:
sizeLimit: 100MiThere was a problem hiding this comment.
Damn, I was creating this PR when creating the prev one with the same issue, forgot to update it.
Thanks for catching it!
|
PR looks good, except for the sample. This should be changed |
Signed-off-by: Ali Ok <aliok@redhat.com>
|
Updated the example |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #43
Looks like this:
I have my own E2E test suite and existing MCP servers worked fine with this branch of the operator: https://github.com/mcp-kube/mcp-lifecycle-operator-e2e-tests/actions/runs/23618657354/job/68792484134#step:10:43