Skip to content

Add conformance tests for same priority disjoint CNPs#385

Open
TheBeeZee wants to merge 1 commit into
kubernetes-sigs:mainfrom
TheBeeZee:same-priority-cnps
Open

Add conformance tests for same priority disjoint CNPs#385
TheBeeZee wants to merge 1 commit into
kubernetes-sigs:mainfrom
TheBeeZee:same-priority-cnps

Conversation

@TheBeeZee

Copy link
Copy Markdown
Contributor

Adds a conformance test case to verify that the implementation correctly applies multiple ClusterNetworkPolicies in the Admin tier sharing the same priority but targeting different subjects (disjoint).

  • Policies: Two CNPs with priority 15 targeting gryffindor and hufflepuff respectively.
  • Assertions: Verifies that allowed traffic for both policies succeeds, and unmatched traffic is correctly blocked by their respective deny rules.

Fixes: #223

@netlify

netlify Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit ca0e307
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-network-policy-api/deploys/6a331b84412874000926061f
😎 Deploy Preview https://deploy-preview-385--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @TheBeeZee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 17, 2026
@danwinship

Copy link
Copy Markdown
Contributor

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, TheBeeZee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2026
@npinaeva

Copy link
Copy Markdown
Member

Hey @TheBeeZee! This issue #223 is assigned to @vpbh did you sync with him?
We also have discussed desired test cases #223 (comment) but yours have both different subjects and different peers

@vpbh

vpbh commented Jun 22, 2026

Copy link
Copy Markdown

Thanks @npinaeva , Blaž beat me to the PR. :) He can continue working on this one. I have started working on issue #103, and have generated this PR for the issue: #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CONFORMANCE] Add Conformance for "same priority ANPs"; disjoint

5 participants