Fix registry inventory key mismatch causing all images to be _LOST_#1731
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Feb 26, 2026
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/artifacts
saschagrunert
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
fix/registry-inventory-key-mismatch
branch
from
f2ebaad to
f3d8404
Compare
ReadRegistries uses full-path registries from GetRegistriesToRead (e.g. gcr.io/k8s-staging-foo/driver) for splitByKnownRegistries, which exact-matches and returns an empty image name. This causes a key mismatch: the inventory is keyed as inv[fullPath][""] but vertexPropsFor looks up inv[basePath]["driver"]. Add a baseRegistries parameter to ReadRegistries so that splitByKnownRegistries uses the original base registry paths for correct splitting, while still reading only the specific repositories needed. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
fix/registry-inventory-key-mismatch
branch
from
f3d8404 to
416e45d
Compare
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
cpanato
approved these changes
Feb 26, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Fixes a regression introduced in v4.3.0 where
GetPromotionEdgespassed full-path registries (with image names appended, e.g.gcr.io/staging/driver) fromGetRegistriesToReadtoReadRegistries.makeTagRecorderused these forsplitByKnownRegistries, which produced an exact match with an empty image name, keying the inventory asinv["gcr.io/staging/driver"][""].However,
vertexPropsForlooks up by the original edge registry nameinv["gcr.io/staging"]["driver"], which never matched, causing every source digest to be marked_LOST_and no images to be promoted.The fix adds
GetBaseRegistriesto collect the original registry contexts (without image name suffixes) from edges, and passes them toReadRegistriesas separatebaseRegistriesfor correct inventory keying.Special notes for your reviewer:
This broke all image promotion in production with v4.3.0. The
post-k8sio-image-promoProw job succeeds but promotes zero images.Does this PR introduce a user-facing change?