Reduce rate limiter log spam during backoff#1745
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Feb 27, 2026
Merged
Reduce rate limiter log spam during backoff#1745k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
fix/reduce-backoff-log-spam
branch
from
eee8129 to
b3f93be
Compare
Remove the per-request "Backoff active" warning that was logged by every goroutine entering the backoff wait, causing hundreds of near-identical log lines. The single "Received 429" log from triggerBackoff is sufficient. Also remove the unused limiter=default log field. Add PrintVersion call and log formatter to the ReplicateSignatures pipeline to match the behavior of the full promotion pipeline. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
fix/reduce-backoff-log-spam
branch
from
b3f93be to
bbf8bc8
Compare
Member
Author
|
@kubernetes-sigs/release-engineering PTAL |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
release-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
triggerBackoffis sufficient.limiter=defaultlog field.PrintVersioncall and log formatter to theReplicateSignaturespipeline to match the full promotion pipeline.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?