Skip to content

Drop the dirty suffix in version number#98

Merged
dims merged 1 commit into
kubernetes-sigs:mainfrom
dims:drop-the-dirty-suffix-in-version-number
Aug 8, 2023
Merged

Drop the dirty suffix in version number#98
dims merged 1 commit into
kubernetes-sigs:mainfrom
dims:drop-the-dirty-suffix-in-version-number

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Aug 8, 2023

some of the operations may end up with ./hack/print-workspace-status.sh returning version with -dirty in it, indicating that an extra modification to one of the files is present or the git workspace is not pristine enough (extra file?). just ignore those for now. (see example below)

[40915:40912 - 0:2038] 09:02:34 [davanum@c889f3bd53ed:o +1] ~/go/src/k8s.io/kubernetes
$ touch a.txt
[40915:40912 - 0:2039] 03:27:00 [davanum@c889f3bd53ed:o +1] ~/go/src/k8s.io/kubernetes
$ hack/print-workspace-status.sh
STABLE_BUILD_GIT_COMMIT f4041204c0029374be6949164c6f184e27408f7e
STABLE_BUILD_SCM_STATUS dirty
STABLE_BUILD_SCM_REVISION v1.29.0-alpha.0.40+f4041204c00293-dirty
STABLE_BUILD_MAJOR_VERSION 1
STABLE_BUILD_MINOR_VERSION 29+
STABLE_DOCKER_TAG v1.29.0-alpha.0.40_f4041204c00293-dirty
STABLE_DOCKER_REGISTRY registry.k8s.io
STABLE_DOCKER_PUSH_REGISTRY staging-k8s.gcr.io
gitCommit f4041204c0029374be6949164c6f184e27408f7e
gitTreeState dirty
gitVersion v1.29.0-alpha.0.40+f4041204c00293-dirty
gitMajor 1
gitMinor 29+
buildDate 2023-08-08T19:27:05Z

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2023
@dims
Copy link
Copy Markdown
Member Author

dims commented Aug 8, 2023

testing in kubernetes/kubernetes#119835

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the drop-the-dirty-suffix-in-version-number branch from fcbab41 to fc67462 Compare August 8, 2023 19:29
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2023
@dims dims merged commit 9973906 into kubernetes-sigs:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants