Avoid overwrtiging existing apparmor profiles#3225
Conversation
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
|
/retest |
Signed-off-by: Cosmin Cojocar <ccojocar@google.com>
|
@ccojocar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This adds a measure in place to avoid overwriting existing apparmor profiles when a new profile
is first installed by checking the
Generationfield of the CRD. In this way, it always toupdate existing profiles which were already installed by the security-profiles operator.
This is a measure to prevent that an attacker will overwrite an existing profile which is already
loaded into the node to alter its permissions.
Which issue(s) this PR fixes:
Does this PR have test?
yes
Special notes for your reviewer:
Does this PR introduce a user-facing change?