[VMOwnedVolumes][Draft] Introduce FSS, CRD, RBACs and controller skeleton#4056
Open
deepakkinni wants to merge 1 commit into
Open
[VMOwnedVolumes][Draft] Introduce FSS, CRD, RBACs and controller skeleton#4056deepakkinni wants to merge 1 commit into
deepakkinni wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Deepak Kinni <deepak.kinni@broadcom.com>
deepakkinni
force-pushed
the
topic/dk016388/vmown-csi-phase0
branch
from
614f049 to
af65243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Phase 0 — Foundation / Infrastructure
VMOwnedVolumes Feature State Switch (FSS) — Register a new VMOwnedVolumes constant in the CSI FSS system (constants.go, ConfigMap watcher) so all new code paths are gated behind it.
CsiVolumeInfo CRD and Go Types — Define a new CsiVolumeInfo CRD (distinct from the existing CnsVolumeInfo) with the spec/status schema from Section 4.1 (spec.volumeID/pvcName/pvName, status.ownershipState/vmName/vmInstanceUUID/diskUUID/diskPath/conditions), cns.vmware.com/disk-uuid label, cvi-protection finalizer, PV ownerReference with blockOwnerDeletion: true, and status subresource.
CsiVolumeInfo RBAC, Informers, and Service Layer — Add RBAC rules, controller-runtime watches/caches, and a CRUD service layer (analogous to the existing cnsvolumeinfo/cnsvolumeinfoservice.go) for the new CsiVolumeInfo CR so controllers can create/read/update/delete CVIs.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.
Special notes for your reviewer:
Release note: