Skip to content

Remove omitempty from accessibleZones in infra SPI CR#4067

Open
skogta wants to merge 1 commit into
kubernetes-sigs:masterfrom
skogta:topic/skogta/group-version
Open

Remove omitempty from accessibleZones in infra SPI CR#4067
skogta wants to merge 1 commit into
kubernetes-sigs:masterfrom
skogta:topic/skogta/group-version

Conversation

@skogta
Copy link
Copy Markdown
Contributor

@skogta skogta commented Jun 3, 2026

What this PR does / why we need it:
This PR removes omitempty from accessibleZones field in infraSPI CRD.
This will better reflect that the accessibleZones list is empty to the devops users.

Testing done:

When no accessible zones are present:

k get infraspi test-policy -oyaml
apiVersion: cns.vmware.com/v1alpha1
kind: InfraStoragePolicyInfo
metadata:
  creationTimestamp: "2026-06-02T15:16:14Z"
  generation: 1
  name: test-policy
  ownerReferences:
  - apiVersion: cns.vmware.com/v1alpha1
    blockOwnerDeletion: false
    controller: false
    kind: ClusterStoragePolicyInfo
    name: test-policy
    uid: 6834ef3d-5c14-49b9-b971-3c846b01c352
  resourceVersion: "736881"
  uid: 9f5f4944-7331-4b3b-bdb3-4e8c035c4cc3
status:
  topology:
    accessibleZones: []
    topologyType: zonal

When accessible zones are present:

k get infraspi -oyaml vm-encryption-policy
apiVersion: cns.vmware.com/v1alpha1
kind: InfraStoragePolicyInfo
metadata:
  creationTimestamp: "2026-06-02T14:23:46Z"
  generation: 1
  name: vm-encryption-policy
  ownerReferences:
  - apiVersion: cns.vmware.com/v1alpha1
    blockOwnerDeletion: false
    controller: false
    kind: ClusterStoragePolicyInfo
    name: vm-encryption-policy
    uid: 871e4b16-50bb-4026-8264-5321f00dc714
  resourceVersion: "138954"
  uid: d46dccc9-80b2-48b3-b071-c7dd87122742
status:
  topology:
    accessibleZones:
    - az1
    topologyType: ""

WCP precheckin (passed): https://jenkins-vcf-csifvt.devops.broadcom.net/job/wcp-instapp-e2e-pre-checkin/1625/
VKS precheckin (passed): https://jenkins-vcf-csifvt.devops.broadcom.net/job/vks-instapp-e2e-pre-checkin/1248/

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skogta
Once this PR has been reviewed and has the lgtm label, please assign kolluria for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2026
@deepakkinni
Copy link
Copy Markdown
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1611

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2026
@skogta skogta changed the title Remove omitemoty from accessibleZones in infra SPI CR Remove omitempty from accessibleZones in infra SPI CR Jun 3, 2026
@deepakkinni
Copy link
Copy Markdown
Collaborator

FAILED --- Jenkins Build #1611

@deepakkinni
Copy link
Copy Markdown
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1618

@deepakkinni
Copy link
Copy Markdown
Collaborator

FAILED --- Jenkins Build #1618

@deepakkinni
Copy link
Copy Markdown
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1620

@deepakkinni
Copy link
Copy Markdown
Collaborator

SUCCESS --- Jenkins Build #1620

@deepakkinni
Copy link
Copy Markdown
Collaborator

Triggering CSI-WCP Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1625

@deepakkinni
Copy link
Copy Markdown
Collaborator

Triggering CSI-TKG Pre-checkin Pipeline for this PR... Job takes approximately an hour to complete
Jenkins Build #1248

@deepakkinni
Copy link
Copy Markdown
Collaborator

SUCCESS --- Jenkins Build #1625

@deepakkinni
Copy link
Copy Markdown
Collaborator

SUCCESS --- Jenkins Build #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants