-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Updated links in sig-apps and sig-auth READMEs #8715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @Aryan-Bagale. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test You actually need to remove these from sigs.yaml as these parts of the README are generated |
|
/cc @kubernetes/sig-auth-leads |
|
@stlaz: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-auth-leads. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aramase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
for sig-auth readme update.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aramase, Aryan-Bagale The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
In sig-apps
directories were removed where OWNER file was, so I remove it from sig-apps README
Updated helm proposal URL
previous - https://github.com/cncf/toc/blob/main/proposals/incubation/helm.adoc
new - https://github.com/cncf/toc/blob/5103bce2ec283a8b641659a10362f10c65a97a08/projects/helm/helm-incubation-proposal.adoc
In sig-auth
directories authentication, authorization, Podsecuritypolicy was removed where OWNER file was so I removed it from sig-auth README