Skip to content

Commit 0e6d109

Browse files
authored
Merge pull request #5324 from serathius/kep-5116-ga
Move KEP-5116 to GA
2 parents c1fbb7f + 01804c9 commit 0e6d109

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 5116
22
beta:
33
approver: "@deads2k"
4+
stable:
5+
approver: "@deads2k"

keps/sig-api-machinery/5116-streaming-response-encoding/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,9 @@ The tests will cover the following properties:
197197
* Different content type JSON (default), Proto, CBOR, YAML.
198198
* Different API kinds, eg ConfigMap, Pod, custom resources
199199

200-
In first iteration we expect we will overallocate the resources needed for apiserver to ensure passage,
201-
however after the improvement is implemented we will tune down the resources to detect regressions.
200+
The tests turned not only a great way to visualize the impact of the work, but also were able to catch [regression in Audit logs memory usage](https://github.com/kubernetes/kubernetes/issues/131720).
201+
To ensure long term sustainability we propose to introduce a release blocking test, that will detect memory regression in apiserver handling large resources.
202+
The test will run a known set of efficient requests and validate that apiserver memory didn't grow above certain threshold.
202203

203204
### Graduation Criteria
204205

@@ -232,7 +233,7 @@ Via feature gates
232233

233234

234235
- [X] Feature gate (also fill in values in `kep.yaml`)
235-
- Feature gate name: StreamingCollectionEncodingToJSON, StreamingCollectionEncodingToProto
236+
- Feature gate name: StreamingCollectionEncodingToJSON, StreamingCollectionEncodingToProtobuf
236237
- Components depending on the feature gate: kube-apiserver
237238

238239
###### Does enabling the feature change any default behavior?

keps/sig-api-machinery/5116-streaming-response-encoding/kep.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@ reviewers:
99
- liggitt
1010
approvers:
1111
- deads2k
12-
stage: beta
13-
latest-milestone: "v1.33"
12+
stage: stable
13+
latest-milestone: "v1.34"
1414
milestone:
1515
beta: "v1.33"
16+
stable: "v1.34"
1617
feature-gates:
1718
- name: StreamingCollectionEncodingToJSON
1819
components:
1920
- kube-apiserver
20-
- name: StreamingCollectionEncodingToProto
21+
- name: StreamingCollectionEncodingToProtobuf
2122
components:
2223
- kube-apiserver

0 commit comments

Comments
 (0)