Move KEP-5116 to GA #5324
Merged
Move KEP-5116 to GA #5324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
serathius
force-pushed
the
kep-5116-ga
branch
2 times, most recently
from
43536a0 to
6d87100
Compare
k8s-ci-robot
added
size/S
14 tasks
|
/cc @liggitt |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
lgtm. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5116
Proposing to move the KEP-5116 to GA.
There were no issues discovered in the implementation, so the only pending work is preventing regressions.
Added some information about regression we have already caught by just eyeballing the graph.
Don't think there is a need to block the GA on implementation of other serialization formats. While they are supported by apiserver, they are not used in Kubernetes core projects (
kubectl get pod -o yamlwill request JSON and generate yaml on client side) and should not be recommended./assign @deads2k @liggitt