Skip to content

Add KEP for DRA: Extended Resource #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Feb 5, 2025

  • One-line PR description:
    Add new KEP for supporting extended resource requests in DRA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 5, 2025
@yliaog
Copy link
Contributor Author

yliaog commented Feb 5, 2025

/assign @johnbelamaric

Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @yliaog

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Feb 6, 2025
@pohly
Copy link
Contributor

pohly commented Feb 6, 2025

/cc

@yliaog yliaog force-pushed the master branch 11 times, most recently from 7ccd621 to a1d3c16 Compare February 6, 2025 23:30
@pohly
Copy link
Contributor

pohly commented Jun 9, 2025

@yliaog: please squash into one commit and keep it like that when making further changes (i.e. amend the commit without rebasing). Then once it has approvals, we can merge directly.

We have LGTM from Sergey for SIG Node, preliminary API review by Jordan, approval from from @dom4ha for SIG Scheduling. I think all that is missing is PRR from @johnbelamaric (or some other PRR reviewer).

@yliaog
Copy link
Contributor Author

yliaog commented Jun 9, 2025

Thanks @pohly, squashed all commits, and I think @johnbelamaric has already approved PRR, so the KEP is ready for merge.

@pohly
Copy link
Contributor

pohly commented Jun 9, 2025

It has John's approval, but it's not clear to me whether that was for PRR. Probably.

Let's hold for a bit longer, perhaps we can get clarification.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2025
@pohly
Copy link
Contributor

pohly commented Jun 10, 2025

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jun 10, 2025
@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Jun 10, 2025
@johnbelamaric
Copy link
Member

/lgtm

@pohly
Copy link
Contributor

pohly commented Jun 10, 2025

Based on #5136 (comment), PRR is done.

@aojea had some recent comments, so let's keep the hold for another day before merging. @aojea: feel free to lift the hold immediately if your concerns have been addressed.

@aojea
Copy link
Member

aojea commented Jun 10, 2025

Based on #5136 (comment), PRR is done.

@aojea had some recent comments, so let's keep the hold for another day before merging. @aojea: feel free to lift the hold immediately if your concerns have been addressed.

commented here #5136 (comment) , non blocking comments, just raise awareness of the risks of having too much flexibility on a transition mechanism

I feel that providing much flexibility to a mechanism that should be only solving the migration from device plugins to dra drivers, can make the scope creeping and we end in a situation like python2 -> python3 or ipv4->ipv6 that nobody nevers moves from the legacy mechanism ... and even worse, people starts building features on top this duality

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 80013a1 into kubernetes:master Jun 10, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Changes Requested to Closed / Done in SIG Auth Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in SIG Scheduling Jun 10, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG Apps Jun 10, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG CLI Jun 10, 2025
@klueska klueska moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/ui Categorizes an issue or PR as relevant to SIG UI. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: API review completed, 1.34
Status: Done
Status: Done
Status: Closed / Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.