-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add KEP for DRA: Extended Resource #5136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign @johnbelamaric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @yliaog
/cc |
7ccd621
to
a1d3c16
Compare
@yliaog: please squash into one commit and keep it like that when making further changes (i.e. amend the commit without rebasing). Then once it has approvals, we can merge directly. We have LGTM from Sergey for SIG Node, preliminary API review by Jordan, approval from from @dom4ha for SIG Scheduling. I think all that is missing is PRR from @johnbelamaric (or some other PRR reviewer). |
Thanks @pohly, squashed all commits, and I think @johnbelamaric has already approved PRR, so the KEP is ready for merge. |
It has John's approval, but it's not clear to me whether that was for PRR. Probably. Let's hold for a bit longer, perhaps we can get clarification. /lgtm |
/wg device-management |
/lgtm |
Based on #5136 (comment), PRR is done. @aojea had some recent comments, so let's keep the hold for another day before merging. @aojea: feel free to lift the hold immediately if your concerns have been addressed. |
commented here #5136 (comment) , non blocking comments, just raise awareness of the risks of having too much flexibility on a transition mechanism
/hold cancel |
Add new KEP for supporting extended resource requests in DRA
DRA: Handle extended resource requests via DRA Driver #5004
kubelet and scheduler for extended resource backed by DRA kubernetes#130653