Skip to content

Update the KEP with clarity around localhost probes #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Jul 3, 2025

Addresses review comment #4942 (comment) from @BenTheElder and @danwinship . Though I removed deprecation area totally I forgot to mention probes using "localhost" IP will continue to be allowed.
cc @deads2k / @liggitt

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
Once this PR has been reviewed and has the lgtm label, please assign ritazh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aramase and liggitt July 3, 2025 08:15
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025
@danwinship
Copy link
Contributor

/retitle Update the KEP with clarity around localhost probes

@k8s-ci-robot k8s-ci-robot changed the title Update the KEP with clarify around localhost probes Update the KEP with clarity around localhost probes Jul 4, 2025
@enj enj added this to SIG Auth Jul 7, 2025
@enj enj moved this to Needs Triage in SIG Auth Jul 7, 2025
@micahhausler micahhausler moved this from Needs Triage to In Review in SIG Auth Jul 7, 2025
@tssurya tssurya force-pushed the update-sig-auth-kep-psa-host-field-on-probes branch from 762bd99 to 05443f3 Compare July 10, 2025 20:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants