Skip to content

Deployment/DaemonSet: Remove distroless from extraModules templating. #10742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 13, 2023
Merged

Deployment/DaemonSet: Remove distroless from extraModules templating. #10742

k8s-ci-robot merged 1 commit into from
Dec 13, 2023

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Dec 9, 2023 •
edited
Loading

What this PR does / why we need it:

This PR removes the distroless argument from the extraModules templating in the Deployment & DaemonSet since this is now part of the controller.extraModules.image & controller.opentelemetry.image object and therefore does not exist anymore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 48631ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/657849037cb0490008e16f7c

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/helm Issues or PRs related to helm charts needs-priority labels Dec 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2023
@Gacko
Copy link
Member Author

Gacko commented Dec 9, 2023

/kind cleanup
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 9, 2023
@Gacko
Copy link
Member Author

Gacko commented Dec 9, 2023

Follow up for #9773. Not really urgent, rather cleaning up a leftover, but useful.

/cc @cpanato @strongjz

@Gacko
Copy link
Member Author

Gacko commented Dec 9, 2023

/assign @strongjz

cpanato
cpanato approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 97d4a83 into kubernetes:main Dec 13, 2023
@Gacko Gacko deleted the v4z4t branch December 13, 2023 10:01
dkostyrev pushed a commit to joomcode/ingress-nginx that referenced this pull request May 30, 2025
@Gacko @dkostyrev
Deployment/DaemonSet: Remove distroless from extraModules templat…
19b0a9d 
…ing. (kubernetes#10742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gacko @k8s-ci-robot @cpanato @strongjz